fix: content type bug introduced in #850 #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts part of #850 to restore correct content-type handling in error paths and updates tests accordingly.
- Updated the test to expect
application/problem+jsonfor 406 errors - Moved header setting into
writeResponsefor both error and normal flows - Removed the final header set in
transformAndWriteand adjusted logic inhuma.go
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| huma_test.go | Changed expected Content-Type from application/json to application/problem+json in the 406 response test |
| huma.go | Added explicit ctx.SetHeader calls in both error and normal branches; removed the original footer header setting |
Comments suppressed due to low confidence (1)
huma.go:498
- The call to
transformAndWritehere uses the hard-coded media type"application/json"rather than the computedctvariable. Consider passingctto keep the marshaller in sync with theContent-Typeheader.
if e := transformAndWrite(api, ctx, http.StatusNotAcceptable, "application/json", notAccept); e != nil {
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
=======================================
Coverage 92.55% 92.56%
=======================================
Files 23 23
Lines 5507 5511 +4
=======================================
+ Hits 5097 5101 +4
Misses 351 351
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts part of #850 and adjusts the code so the tests for it still pass while maintaining the correct overall behavior for setting the content type.
Fixes #851