Revert "fix: export of embed properties when struct type is not exported" #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous fix regarding the export of embed properties for unexported struct types due to issues with the stdlib JSON serializer ignoring private embedded fields. Key changes include:
- Removing the type definition of embedWithExported and its associated test cases.
- Reverting modifications in the schema generation logic to exclude tests verifying serialization of unexported embedded fields.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| schema_test.go | Removed embedWithExported type and test cases related to unexported embeds. |
| schema.go | Simplified field filtering logic by removing redundant checks for exported status. |
Comments suppressed due to low confidence (2)
schema_test.go:1329
- The removal of TestUnexportedEmbed reduces test coverage for unexported embedded fields; consider providing an alternative test or a comment explaining why this removal is acceptable.
err = json.Unmarshal([]byte(`{"field": null}`), &o)
schema.go:643
- [nitpick] The inline comment referencing 'embeds can have exported fields' appears outdated after the recent change; consider updating or removing it to avoid confusion.
if f.Anonymous {
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
- Coverage 92.47% 92.47% -0.01%
==========================================
Files 23 23
Lines 5502 5501 -1
==========================================
- Hits 5088 5087 -1
Misses 354 354
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #822. With some additional testing this appears to not be working correctly. The stdlib JSON serializer is ignoring these private embedded fields. We should revisit this and see if there is a solution that can work.