feat: add humagin.NewContext #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a constructor function to the humagin adapter to allow creating a huma.Context from an existing Gin context, facilitating easier testing of middleware that relies on humagin.Unwrap.
- Introduces
NewContextto wrap*gin.Contextinto ahuma.Context - Aligns with other adapter constructors in the codebase
Comments suppressed due to low confidence (3)
adapters/humagin/humagin.go:133
- [nitpick] The comment could be clarified to mention that this wraps a Gin context into a
huma.Context, e.g., “NewContext wraps a*gin.Contextand*huma.Operationinto ahuma.Context.”
// NewContext creates a new Huma context from an HTTP request and response.
adapters/humagin/humagin.go:134
- [nitpick] The parameter name
cis ambiguous; consider renaming it toginCtxorctxto improve readability.
func NewContext(op *huma.Operation, c *gin.Context) huma.Context {
adapters/humagin/humagin.go:134
- There are no tests covering this new constructor; adding unit tests to verify that
humagin.Unwrap(NewContext(...))returns the original Gin context would ensure correct behavior.
func NewContext(op *huma.Operation, c *gin.Context) huma.Context {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into difficulties testing a middleware that used
humagin.UnwrapSinceginCtxis not exported, it's not easy to create a huma.Context compatible with humagin.Unwrap.Adding
NewContextlike some of the other adapters seems logical