feat: schema handler can now handle schema names with special characters #81
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go types can have a `.` in them but the `chi` router can't handle this if the non-parameter part of the route starts with (contains?) a `.`. Given all the potential other special characters in a Go type name (in the context of generics), it was easier to just use a wildcard and check for the proper suffix. In the future, it would be pretty easy to add support for a `.yaml` prefix. The error handler here was pretty bare bones. It didn't respond with RFC 7807 problems, etc. So I made a more consistent error writer. This is all to address issue danielgtaylor#74.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go types can have a
.in them but thechirouter can't handle this if the non-parameter part of the route starts with (contains?) a.. Given all the potential other special characters in a Go type name (in the context of generics), it was easier to just use a wildcard and check for the proper suffix.In the future, it would be pretty easy to add support for a
.yamlprefix.The error handler here was pretty bare bones. It didn't respond with RFC 7807 problems, etc. So I made a more consistent error writer.
This is all to address issue #74.