fix: this uses proper schema path for errors #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
@danielgtaylor Do you want me to reimplement this by fetching the |
Owner
|
@mtiller I think that would be great as it's a less intrusive change, thanks! |
Contributor
|
@danielgtaylor OK, I think this is a much cleaner diff now. |
Contributor
|
Is there anything you want me to do before merging this? I'm still seeing issues related to schemas for generics that I'd like to fix. But ideally I'd like to build that on top of this PR. |
Owner
|
Sorry, this got away from me during the holidays, thank you for the contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This propagates various router properties (where possible) and then uses those properties (specifically
schemaPath)when generating error messages. This should address issue #79.