minor: use ErrUnknownContentType in more places #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
api.go:303
- Consider adding tests to verify that errors returned with ErrUnknownContentType correctly unwrap to the intended error.
return ct, fmt.Errorf("%w: %s", ErrUnknownContentType, ct)
api.go:326
- Consider adding tests to verify that errors returned with ErrUnknownContentType correctly unwrap to the intended error.
return fmt.Errorf("%w: %s", ErrUnknownContentType, ct)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 23 23
Lines 5296 5296
=======================================
Hits 4931 4931
Misses 313 313
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR just extends the usage of ErrUnknownContentType to a couple more places where the error was not being wrapped and the error string was being duplicated.
AFAICT that shouldn't have any negative side-effects, except for making error testing a bit more consistent?