Add merging of allOf schemas. Fixes #787 #794
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef6e29a to
022f79e
Compare
Owner
|
FYI left a comment on the issue: #787 (comment) |
Contributor
Author
|
@danielgtaylor thank you for the comment. I'm closing the PR, since it doesn't make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I've prepared a fix for #787.
There are a few considerations that need to be taken into account:
Type: integer) and object types ( old tests are working; new added ).AllOfcases (AllOfthat hasAllOf).Properties,Required, andMin*/Maxfields for now.I propose extending this logic case by case since covering every possible case ( or at least 90% of them ) is a time-consuming and complex task.
@danielgtaylor, please let me know what you think about this change.
Thank you.