Add WithIndex to PathBuffer #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as `With()`, but takes and int, calls `PushIndex`, converts to a string, then pops.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new helper method, WithIndex, for PathBuffer to easily combine pushing an index into a buffer, converting it to a string, and popping the value.
- Adds a WithIndex method in validate.go with accompanying inline documentation.
- Includes a new test in validate_test.go to verify the expected string formatting with an index.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| validate_test.go | Added test for WithIndex functionality |
| validate.go | Introduced WithIndex method with documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 93.10% 93.11%
=======================================
Files 23 23
Lines 5296 5301 +5
=======================================
+ Hits 4931 4936 +5
Misses 313 313
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as
With(), but takes and int, callsPushIndex, converts to a string, then pops.Found myself wishing for this functionality today, but not a deal breaker if it doesn't make it in. Just a little more convenient.
I did not see any tests for pathbuffer itself, but since this method wouldn't be covered elsewhere I added a test for it.