Fix panic when sending an empty file field in a form #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic that occurs when an empty file field is submitted as part of a multipart form.
- The change adds a condition that treats an empty string in form.Value[p.Name] as a missing parameter.
- This prevents accessing a non-existent file when form.File[p.Name] is also missing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 23 23
Lines 5296 5296
=======================================
Hits 4931 4931
Misses 313 313
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic on empty file field in RawBody
Problem
When an empty file field is submitted in a form (
multipart/form-data),form.Valuecontains an empty string (""), butform.Fileis missing. This leads to a panic with the error:unsupported param type huma.FormFileSolution
Now, before accessing
form.Value[p.Name], we check if the value is an empty string and handle it correctly. If the parameter is required and not a valid file, a proper validation error is returned instead of causing a panic.