fix: serialization of []http.Cookie #778
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the serialization issue for []http.Cookie by skipping header processing for cookie slices. Key changes include:
- Adding a new field (ShouldSkip) to headerInfo to mark headers that should not be serialized.
- Introducing a lambda in findHeaders to detect cookie slices and mark them accordingly.
- Adjusting recursive processing in _findInType to respect the new skip flag.
Comments suppressed due to low confidence (1)
huma.go:413
- [nitpick] Consider renaming 'resolved' to a more descriptive name such as 'headerFound' to better convey its purpose.
resolved := false
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 93.10% 93.00% -0.11%
==========================================
Files 23 23
Lines 5296 5301 +5
==========================================
- Hits 4931 4930 -1
- Misses 313 317 +4
- Partials 52 54 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can this be merged and released please? This is a huge bug and it's stopping us from implement a cookie based authentication. When we try to set multiple cookies using the slices syntax, it's setting the first one as whole. Then it adds another Set-Cookie with all the cookies combined by |
Fixes #776