fix: better integer validation checks #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves integer validation by introducing an early check using math.Trunc to better handle cases when floating point values are mistakenly passed as integers.
- Update the validation logic in validate.go to distinguish between integers and non-integer numbers.
- Adjust test cases in validate_test.go to expect "expected integer" errors instead of "expected number."
- Introduce a new error message constant in validation/messages.go to support the updated error messaging.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| validate.go | Added checks for integer validation using math.Trunc and updated error messages accordingly |
| validate_test.go | Updated test cases to reflect the new integer error message expectation |
| validation/messages.go | Added a new error message constant for integer validation |
Comments suppressed due to low confidence (1)
validate.go:431
- [nitpick] Consider consolidating the error message logic for integer validation. Currently, the error message for non-matching types is added in two places; refactoring this could improve maintainability.
if s.Type == TypeInteger {
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 93.05% 93.06%
=======================================
Files 23 23
Lines 5254 5261 +7
=======================================
+ Hits 4889 4896 +7
Misses 313 313
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional check for integers using
math.Trunc(...)to try and fail earlier with a more reasonable error message for users passing in floating point values for integers.Fixes #745. (not entirely, but it's an improvement)