feat: groups #728
Merged
feat: groups #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/docs/features/middleware.md:204
- The phrase 'the API instance' should be corrected to 'list of middleware'.
- [`huma.Middlewares`](https://pkg.go.dev/github.com/danielgtaylor/huma/v2#Middlewares) the API instance
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 92.78% 93.00% +0.21%
==========================================
Files 22 23 +1
Lines 5062 5246 +184
==========================================
+ Hits 4697 4879 +182
- Misses 314 315 +1
- Partials 51 52 +1 ☔ View full report in Codecov by Sentry. |
|
This is exactly what we needed ! Thanks @danielgtaylor. |
Open
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- docs/docs/features/middleware.md: Evaluated as low risk
Comments suppressed due to low confidence (2)
group_test.go:143
- [nitpick] Using
assert.Panicsmight not be the best way to handle errors. Consider adding more specific error handling tests to ensure proper error handling.
assert.Panics(t, func() { api.Get("/v1/users") })
group.go:23
- Ensure that the prefix is not an empty string before modifying the OperationID and Tags.
if len(prefixes) > 1 && prefix != "" {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Groupstruct & feature that takes the functionality of the excellent https://github.com/cardinalby/hureg library and ports it into Huma's core. Basic functionality looks like this:Check out the included docs for more info!
Related to #719.
Fixes #489.