fix: allow providing a custom request schema #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
+ Coverage 92.77% 92.78% +0.01%
==========================================
Files 22 22
Lines 5051 5062 +11
==========================================
+ Hits 4686 4697 +11
Misses 314 314
Partials 51 51 ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
huma.go:1027
- The indentation and structure of the conditional checks should be improved for readability and to prevent logic errors. Ensure that the checks for 'op.RequestBody.Content[contentType] == nil' and 'op.RequestBody.Content[contentType].Schema == nil' are clearly separated and properly indented.
if op.RequestBody.Content[contentType] == nil {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to provide a custom request schema along with a body by preventing Huma from overwriting any existing schema for the default content type.