fixed work with fiber.Ctx, fiber.UserContext - fixed graceful shutdown and race condition on access to huma.Context outside handler #725
Conversation
01bf44f to
21f7dbf
Compare
…n and race condition on access to huma.Context outside handler
21f7dbf to
3e2188a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 22 22
Lines 5027 5027
=======================================
Hits 4665 4665
Misses 312 312
Partials 50 50 ☔ View full report in Codecov by Sentry. |
8aba0f9 to
2cd0f27
Compare
|
@danielgtaylor I hope this it the final fix of "humafiver" provider. In this Pull Request I have the reproduction case to illustrate issues with fasthttp/fiber in case when user-side code ignores recommentations about fiber/fasthttp (and without penalties for that!) This test failed with current "master" implementation, but works perfectly with fixed one |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
adapters/humafiber/humafiber.go:141
- [nitpick] The name 'contextWrapperValue' is ambiguous. Consider renaming it to 'ContextKeyValuePair' for clarity.
type contextWrapperValue struct {
adapters/humafiber/humafiber.go:146
- [nitpick] The name 'contextWrapper' is ambiguous. Consider renaming it to 'ContextWithValues' for clarity.
type contextWrapper struct {
Fiber and FastHttp has the very strict rules how to work with Context() and UserContext()
If some huma-based application, whatever reason, has references to context.Context outside of Huma handler, then fiber/fasthttp RequestCtx does not work as expected, the most likely you receive crash or race-condition
To prevent race conditions and possible issues with graceful shutdown of the servers, this pull request completely fix the way on how fiber and huma integrated.
It also include golang tests to detect race conditions.