fix: better handling of zero values; no panic for generic types #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
- Coverage 86.13% 86.10% -0.04%
==========================================
Files 24 24
Lines 1890 1893 +3
==========================================
+ Hits 1628 1630 +2
- Misses 185 186 +1
Partials 77 77
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for how zero values were getting turned into a map.
Also updates the code to support generating schemas and GraphQL from the new Go 1.18 generics (type parameters) feature, which introduces some new fields into the generated types at compile time that we need to ignore.