feat(validation): flexible validation messages for pattern tag #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadable validation messages when using patterns
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage 95.13% 95.14%
=======================================
Files 19 19
Lines 2777 2782 +5
=======================================
+ Hits 2642 2647 +5
Misses 98 98
Partials 37 37 ☔ View full report in Codecov by Sentry. |
danielgtaylor
approved these changes
Mar 18, 2024
Owner
danielgtaylor
left a comment
There was a problem hiding this comment.
@purin-dev awesome feature; thank you! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
patternDescriptionstruct tag to allow for human-readable error messages when using the pattern tag.Error messages are formatted like
expected string to be {description}- this allows the user to use their own articles while still being consistent with the other validators