这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: allow response types to contain unexported fields #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: allow response types to contain unexported fields #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions transforms.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,11 @@ func (t *SchemaLinkTransformer) OnAddOperation(oapi *OpenAPI, op *Operation) {
}
for i := 0; i < typ.NumField(); i++ {
f := typ.Field(i)
fields = append(fields, f)
if f.IsExported() {
// Track which fields are exported so we can copy them over. It's
// preferred to track/compute this here to avoid allocations in
fields = append(fields, f)

// Track which fields are exported, so we can copy them over.
// It's preferred to track/compute this here to avoid allocations in
// the transform function from looking up what is exported.
fieldIndexes = append(fieldIndexes, i)
}
Expand Down Expand Up @@ -155,8 +156,13 @@ func (t *SchemaLinkTransformer) Transform(ctx Context, status string, v any) (an

// Copy over all the exported fields.
vv := reflect.Indirect(reflect.ValueOf(v))
for _, i := range info.fields {
tmp.Field(i + 1).Set(vv.Field(i))
for i, j := range info.fields {
// Field 0 is the $schema field, so we need to offset the index by one.
// There might have been unexported fields in the struct declared in the schema,
// but these have been filtered out when creating the new type.
// Therefore, the field with index i on the new type maps to the field with index j
// in the original struct.
tmp.Field(i + 1).Set(vv.Field(j))
}

return tmp.Addr().Interface(), nil
Expand Down