fix: allow example/enum tags for custom schemas #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 18 18
Lines 2609 2648 +39
=======================================
+ Hits 2465 2502 +37
- Misses 106 107 +1
- Partials 38 39 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the
exampleandenumfield tags are processed to enable using them for types which provide a custom schema, such asOmittableNullable[int]. The type checking now happens via the JSON Schema rather than the Go type, enabling a custom type which says it's an e.g.integerto match with enum values like1,2,3.Note: this does not enable the use of defaults with type that provide custom schemas. Since defaults need to be type-cast to the Go type and assigned dynamically this is not currently possible with custom types.
Fixes #228