fix: resolver should never be invoked twice #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 94.39% 94.48% +0.08%
==========================================
Files 18 18
Lines 2606 2609 +3
==========================================
+ Hits 2460 2465 +5
+ Misses 107 106 -1
+ Partials 39 38 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case with composition, where a single anonymous field contains a
Resolvemethod, which would get promoted by the Go compiler and be indistinguishable from a hand-written resolver method, resulting in the method being invoked twice (once on the parent, once on the actual struct with the resolver).Now, when a type is found that matches one of the resolver interfaces, only named fields will continue to be traversed into to find other resolvers, skipping any anonymous fields whose method has been promoted or overwritten.
Fixes #234.