Errors in OAuth2 how to examples #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 17 17
Lines 2189 2189
=======================================
Hits 2044 2044
Misses 106 106
Partials 39 39 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I can use ctx.SetStatus(http.StatusUnauthorized)
ctx.BodyWriter().Write([]byte(http.StatusText(http.StatusUnauthorized)))But it looks kinda ugly. |
Owner
|
@x-user thanks for fixing this up! You could maybe pass the api.UseMiddleware(NewAuthMiddleware(api, "https://example.com/.well-known/jwks.json")) |
Contributor
Author
|
Yes closures can solve this. Then i will make it this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor errors in OAuth2 how to, but huma.WriteErr requires huma.API as first argument and there no way to obtain it in middleware. I was thinking about replacing it with http.Error, but it requires http.ResponseWriter and huma.Context doesn't implement it. So i'm stuck there.