这是indexloc提供的服务，不要输入任何密码
Skip to content

log accurate error message when there's duplicate registry name #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

log accurate error message when there's duplicate registry name #217

merged 1 commit into from
Jan 24, 2024

Conversation

@qdongxu
Copy link
Contributor

@qdongxu qdongxu commented Jan 24, 2024

print the exact conflict items:

panic: duplicate name: ResponseGenericOrderData, new type: main.Response[my-app/module/submodule2.Generic[my-app/module/submodule2.OrderData]], existing type: main.Response[my-app/module/submodule.Generic[my-app/module/submodule.OrderData]]

the original log message is hard to read especially when there's tens of API entries:

panic: duplicate name ResponseGenericOrderData does not match existing type. New type main.Response[my-app/module/submodule2.Generic[my-app/module/submodule2.OrderData]], have existing types map[submodule.Generic[my-app/module/submodule.BizData]:true submodule.Generic[my-app/module/submodule.OrderData]:true submodule.BizData:true submodule.OrderData:true huma.ErrorDetail:true main.Response[my-app/module/submodule.Generic[my-app/module/submodule.BizData]]:true main.Response[my-app/module/submodule.Generic[my-app/module/submodule.OrderData]]:true huma.ErrorModel:true]

@codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (02fcf4e) 93.45% compared to head (b6ee970) 93.46%.
Report is 2 commits behind head on main.

Files Patch % Lines
registry.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   93.45%   93.46%           
=======================================
  Files          17       17           
  Lines        2186     2187    +1     
=======================================
+ Hits         2043     2044    +1     
  Misses        105      105           
  Partials       38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdongxu qdongxu mentioned this pull request Jan 24, 2024
Closed
@danielgtaylor danielgtaylor merged commit f524213 into danielgtaylor:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielgtaylor danielgtaylor danielgtaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qdongxu @danielgtaylor