这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: set response status after transforms #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: set response status after transforms #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions huma.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ func transformAndWrite(api API, ctx Context, status int, ct string, body any) {
ctx.BodyWriter().Write([]byte("error transforming response"))
panic(fmt.Sprintf("error transforming response %+v for %s %s %d: %s\n", tval, ctx.Operation().Method, ctx.Operation().Path, status, terr.Error()))
}
ctx.SetStatus(status)
if merr := api.Marshal(ctx.BodyWriter(), ct, tval); merr != nil {
ctx.BodyWriter().Write([]byte("error marshaling response"))
panic(fmt.Sprintf("error marshaling response %+v for %s %s %d: %s\n", tval, ctx.Operation().Method, ctx.Operation().Path, status, merr.Error()))
Expand Down Expand Up @@ -916,7 +917,6 @@ func Register[I, O any](api API, op Operation, handler func(context.Context, *I)
ct = ctf.ContentType(ct)
}

ctx.SetStatus(status)
ctx.SetHeader("Content-Type", ct)
transformAndWrite(api, ctx, status, ct, err)
return
Expand Down Expand Up @@ -989,7 +989,6 @@ func Register[I, O any](api API, op Operation, handler func(context.Context, *I)
ctx.SetHeader("Content-Type", ct)
}

ctx.SetStatus(status)
transformAndWrite(api, ctx, status, ct, body)
} else {
ctx.SetStatus(status)
Expand Down