Fix: Update transforms.go to use explicit Host function from huma.Context #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chi does not provide the Host header through the Header func but it is explicitly available via the Host func.
danielgtaylor
approved these changes
Oct 17, 2023
Owner
danielgtaylor
left a comment
There was a problem hiding this comment.
This was on my short list of things to fix ASAP but you beat me to it, thank you! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @danielgtaylor 👋🏼
Firstly - just found Huma and loving it - very quickly I've been able to get a TRPC-like workflow running which is amazing.
It looks like Chi does not provide the Host header through the Header func but it is explicitly available via the Host func. This meant the
$schemanever had a hostname and would returnhttps:///schema....