fix: properly instantiate nested schemas, replaces #86 #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 86.72% 85.85% -0.88%
==========================================
Files 25 25
Lines 2245 2269 +24
==========================================
+ Hits 1947 1948 +1
- Misses 213 236 +23
Partials 85 85
☔ View full report in Codecov by Sentry. |
4e1284c to
7ff84ae
Compare
7ff84ae to
d564364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work from #86, and reverts the new behavior to be behind a feature flag that must be enabled to not break existing service's generated SDKs. To enable the new behavior, just set
schema.GenerateInline = false.