fix: adapters/humafiber - prevent to use *fiber.Ctx and *fasthttp.RequestCtx outside handler, fixes #686 #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 22 22
Lines 4915 4915
=======================================
Hits 4560 4560
Misses 308 308
Partials 47 47 ☔ View full report in Codecov by Sentry. |
…uestCtx outside handler, fixes danielgtaylor#686
Contributor
Author
|
@danielgtaylor hello! |
1 similar comment
Contributor
Author
|
@danielgtaylor hello! |
Owner
|
@excavador sorry for the delay, I've been busy over the holidays and am getting back to catching up on Huma stuff now 👀 |
danielgtaylor
approved these changes
Jan 13, 2025
Owner
|
Link to #686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.