这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix GraphQL field casing by camel casing the path #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Fix GraphQL field casing by camel casing the path #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83d0bb8
fix: use camel casing on last path param to adhere to graphQL regex
jpkalbacher Sep 12, 2022
8221929
remove temporary comments
jpkalbacher Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions graphql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ func (r *Router) handleOperation(config *GraphQLConfig, parentName string, field
}
break
}
last = casing.LowerCamel(last)

// Setup input arguments (i.e. OpenAPI operation params).
args := graphql.FieldConfigArgument{}
Expand Down
25 changes: 23 additions & 2 deletions graphql_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,21 @@ type StoreSummary struct {
ID string `json:"id" graphParam:"store-id" doc:"Store ID"`
}

type StoreName struct {
Name string `json:"name" graphParam:"store-name" doc:"Store Name"`
}

type Store struct {
StoreName
StoreSummary
URL string `json:"url" doc:"Web link to buy product"`
}

func TestGraphQL(t *testing.T) {
now, _ := time.Parse(time.RFC3339, "2022-02-22T22:22:22Z")

amazon := &Store{StoreSummary: StoreSummary{ID: "amazon"}, URL: "https://www.amazon.com/"}
target := &Store{StoreSummary: StoreSummary{ID: "target"}, URL: "https://www.target.com/"}
amazon := &Store{StoreSummary: StoreSummary{ID: "amazon"}, URL: "https://www.amazon.com/", StoreName: StoreName{"amazon"}}
target := &Store{StoreSummary: StoreSummary{ID: "target"}, URL: "https://www.target.com/", StoreName: StoreName{"target"}}

xsx := &Product{ProductSummary: ProductSummary{ID: "xbox_series_x"}, SuggestedPrice: 499.99, Created: &now, Metadata: map[string]string{"foo": "bar"}, stores: map[string]*Store{"amazon": amazon, "target": target}, Empty: &struct{}{}}
ps5 := &Product{ProductSummary: ProductSummary{ID: "playstation_ps5"}, SuggestedPrice: 499.99, Created: &now, stores: map[string]*Store{"amazon": amazon}}
Expand Down Expand Up @@ -194,6 +199,21 @@ func TestGraphQL(t *testing.T) {
ctx.WriteModel(http.StatusOK, categories[input.CategoryID].products[input.ProductID].stores[input.StoreID])
})

app.Resource("/categories/{category-id}/products/{product-id}/stores/{store-id}/store-name").Get("get-store-name", "doc",
NewResponse(http.StatusOK, "").Model(&StoreName{}),
NewResponse(http.StatusNotFound, "").Model(&ErrorModel{}),
).Run(func(ctx Context, input struct {
CategoryParam
ProductParam
StoreID string `path:"store-id" doc:"Store ID"`
}) {
if categories[input.CategoryID] == nil || categories[input.CategoryID].products[input.ProductID] == nil {
ctx.WriteError(http.StatusNotFound, "Not found")
return
}
ctx.WriteModel(http.StatusOK, categories[input.CategoryID].products[input.ProductID].stores[input.StoreID].StoreName)
})

app.Resource("/ignored").Get("get-ignored", "doc",
NewResponse(http.StatusOK, "").Model(struct{ ID string }{}),
).Run(func(ctx Context) {
Expand Down Expand Up @@ -326,6 +346,7 @@ data:
- name: categoriesItem
- name: products
- name: productsItem
- name: storeName
- name: stores
- name: storesItem
`, "\t", " ", -1), w.Body.String())
Expand Down