Files that changed from the base of the PR and between b509335 and 2587949.

• huma_test.go (1 hunks)
• openapi.go (3 hunks)

openapi.go (4)

54-71: Comprehensive nil check implementation

The new isNilValue function is a well-implemented utility that enhances nil checks beyond simple equality. It correctly handles various types such as channels, functions, interfaces, maps, pointers, and slices using reflection. This addition will improve the robustness of nil checks throughout the codebase.

---

978-978: Fix for marshaling empty security object

This change addresses the issue described in #593 by using omitNil instead of omitEmpty for the security field. This ensures that an empty array [] is properly marshaled, which is semantically significant in OpenAPI for indicating that a route should be publicly accessible. The change aligns perfectly with the PR objectives and resolves the limitation in the previous implementation.

---

79-79: Appropriate usage of new isNilValue function

The new isNilValue function is correctly utilized in the marshalJSON function, enhancing the nil check for fields marked with omitNil. This usage aligns well with the function's purpose and improves the overall robustness of the JSON marshaling process.

Additionally, the change to the Operation struct's MarshalJSON method appears to be isolated and doesn't seem to have any unintended consequences on other parts of the code.

---

Line range hint 54-978: Summary of changes and overall impact

The changes in this file effectively address the issue of marshaling empty security objects in OpenAPI specifications. The introduction of the isNilValue function provides a robust way to check for nil values across various types, which is then utilized in the JSON marshaling process. The modification to the Operation struct's MarshalJSON method ensures that empty security arrays are correctly represented, allowing for the specification of publicly accessible routes.

These changes are focused, clean, and solve the problem without introducing unnecessary complexity. Moreover, the isNilValue function has potential for broader use throughout the codebase, adding value beyond this specific fix.

Overall, these modifications improve the accuracy and flexibility of the OpenAPI specification generation, particularly in handling security-related configurations.

huma_test.go (1)

1795-1812: LGTM! New test case for security override feature.

The new test case "security-override-public" has been added to the TestFeatures function. It tests the ability to override security settings for a specific endpoint, making it publicly accessible. The implementation looks correct and follows the existing pattern of other test cases in this function.

Key points:

1. The test registers a new GET operation at the path "/public".
2. It sets an empty security array, effectively making the endpoint public.
3. The test verifies that the OpenAPI document correctly serializes the empty security array as "security":[].

This addition enhances the test coverage for the security override feature and ensures that the OpenAPI documentation accurately reflects the security settings.