-
-
Notifications
You must be signed in to change notification settings - Fork 214
docs: add new testimonial to README #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in this pull request focus on updating the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 22 22
Lines 3915 3915
=======================================
Hits 3634 3634
Misses 236 236
Partials 45 45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
README.md (2)
104-104
: Consider rephrasing the informal language in the testimonial.The testimonial contains informal language, specifically the word "kinda". While this preserves the authenticity of the user's comment, you might want to consider either:
- Adding a "[sic]" notation to indicate that the informal language is part of the original quote.
- Rephrasing it slightly to maintain a more consistent tone with the rest of the documentation.
For example:
- ...automatic body and parameter serialization, kinda feels like doing dotnet web APIs, but... + ...automatic body and parameter serialization, [which] feels similar to developing dotnet web APIs, but...🧰 Tools
🪛 LanguageTool
[style] ~104-~104: The word ‘kinda’ is informal. Consider replacing it.
Context: ...matic body and parameter serialization, kinda feels like doing dotnet web APIs, but f...(KINDA)
Line range hint
115-173
: Comprehensive "Hello World" example added.The new "Example" section provides a complete and well-explained "Hello World" application using Huma. This is extremely valuable for new users to quickly understand how to set up a basic application with the framework. The inclusion of the CLI setup, route definition, and handler implementation gives a holistic view of working with Huma.
The tip about using the standard library router from Go 1.22+ is also very helpful, showing Huma's flexibility and forward-compatibility.
To further enhance this section, consider adding a brief explanation of what each part of the example does, especially for newcomers to Go or API development. For instance:
// Create a CLI app which takes a port option. cli := humacli.New(func(hooks humacli.Hooks, options *Options) { // This sets up the command-line interface for your application // ... }) // Add the operation handler to the API. huma.Get(api, "/greeting/{name}", func(ctx context.Context, input *struct{ // This defines the API endpoint and its input parameters // ... })🧰 Tools
🪛 LanguageTool
[uncategorized] ~102-~102: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Go with Huma and SQL C. Things just work and I seldomly have to debug where in Pytho...(COMMA_COMPOUND_SENTENCE)
[style] ~102-~102: ‘a majority of’ might be wordy. Consider a shorter alternative.
Context: ...y have to debug where in Python I spent a majority of my time debugging. - [Bitclick_](https...(EN_WORDINESS_PREMIUM_A_MAJORITY_OF)
[style] ~104-~104: The word ‘kinda’ is informal. Consider replacing it.
Context: ...matic body and parameter serialization, kinda feels like doing dotnet web APIs, but f...(KINDA)
🪛 Markdownlint
101-101: null
Blank line inside blockquote(MD028, no-blanks-blockquote)
103-103: null
Blank line inside blockquote(MD028, no-blanks-blockquote)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~104-~104: The word ‘kinda’ is informal. Consider replacing it.
Context: ...matic body and parameter serialization, kinda feels like doing dotnet web APIs, but f...(KINDA)
🔇 Additional comments (3)
README.md (3)
104-105
: New testimonial added successfully.The new testimonial provides valuable user feedback and highlights key features of Huma, such as automatic body and parameter serialization. It also draws a comparison with .NET web APIs, which could be helpful for developers familiar with that ecosystem.
🧰 Tools
🪛 LanguageTool
[style] ~104-~104: The word ‘kinda’ is informal. Consider replacing it.
Context: ...matic body and parameter serialization, kinda feels like doing dotnet web APIs, but f...(KINDA)
Line range hint
107-113
: Go version requirement clearly specified.The addition of the Go version requirement (1.21 or newer) in the installation instructions is helpful and prevents potential compatibility issues for users. This information is crucial for a smooth installation process.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~102-~102: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Go with Huma and SQL C. Things just work and I seldomly have to debug where in Pytho...(COMMA_COMPOUND_SENTENCE)
[style] ~102-~102: ‘a majority of’ might be wordy. Consider a shorter alternative.
Context: ...y have to debug where in Python I spent a majority of my time debugging. - [Bitclick_](https...(EN_WORDINESS_PREMIUM_A_MAJORITY_OF)
[style] ~104-~104: The word ‘kinda’ is informal. Consider replacing it.
Context: ...matic body and parameter serialization, kinda feels like doing dotnet web APIs, but f...(KINDA)
🪛 Markdownlint
101-101: null
Blank line inside blockquote(MD028, no-blanks-blockquote)
103-103: null
Blank line inside blockquote(MD028, no-blanks-blockquote)
Line range hint
1-173
: Overall improvements to the README are commendable.The changes made to the README.md file significantly enhance the documentation for the Huma framework. Key improvements include:
- Addition of a new, relevant testimonial that highlights Huma's strengths.
- Clear specification of the required Go version for installation.
- Introduction of a comprehensive "Hello World" example that demonstrates key features of Huma.
- Inclusion of tips for using Huma with newer Go versions.
These updates make the documentation more informative, user-friendly, and likely to attract new users to the framework. Great job on improving the onboarding experience for potential Huma users!
🧰 Tools
🪛 LanguageTool
[uncategorized] ~102-~102: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Go with Huma and SQL C. Things just work and I seldomly have to debug where in Pytho...(COMMA_COMPOUND_SENTENCE)
[style] ~102-~102: ‘a majority of’ might be wordy. Consider a shorter alternative.
Context: ...y have to debug where in Python I spent a majority of my time debugging. - [Bitclick_](https...(EN_WORDINESS_PREMIUM_A_MAJORITY_OF)
[style] ~104-~104: The word ‘kinda’ is informal. Consider replacing it.
Context: ...matic body and parameter serialization, kinda feels like doing dotnet web APIs, but f...(KINDA)
🪛 Markdownlint
101-101: null
Blank line inside blockquote(MD028, no-blanks-blockquote)
103-103: null
Blank line inside blockquote(MD028, no-blanks-blockquote)
This adds a testimonial from a recent discussion to the README.
Summary by CodeRabbit