Huma now accepts naked boolean queryparams #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 86.63% 86.64% +0.01%
==========================================
Files 24 24
Lines 1930 1932 +2
==========================================
+ Hits 1672 1674 +2
Misses 183 183
Partials 75 75
Continue to review full report at Codecov.
|
resolver.go
Outdated
Comment on lines
278
to
280
| } else if req.URL.Query().Has(name) { | ||
| // name has no associated value, but exists in the map of QueryParams. This is a boolean value | ||
| pv = "true" |
Owner
There was a problem hiding this comment.
I think we also need to check that the type is a boolean here, otherwise for your example tests below I think going GET /?s=&b will actually set the string to "true" rather than "". It's an edge case for sure, but probably one we want to avoid if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today in order to use a boolean with queryparams it needs to be set like this:
?param=true, now you can set it with?paramor?param