这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix/is reactive #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix/is reactive #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a90ba69
fix:isReadonly & isReactive pass extreme case
exwer May 7, 2022
142b41a
fix:make ReactiveFlags const
exwer May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/reactivity/__tests__/reactive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ describe("reactive", () => {
expect(observed).not.toBe(original);
expect(isReactive(observed)).toBe(true);
expect(isReactive(original)).toBe(false);
// hack
const evil = {
__v_isReactive: true,
__v_isReadonly: true,
}
expect(isReactive(evil)).toBe(false)
// get
expect(observed.foo).toBe(1);
// // has
Expand Down
6 changes: 6 additions & 0 deletions src/reactivity/__tests__/readonly.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ describe("readonly", () => {
expect(isReadonly(wrapped.bar)).toBe(true);
expect(isReactive(original.bar)).toBe(false);
expect(isReadonly(original.bar)).toBe(false);
// hack
const evil = {
__v_isReactive: true,
__v_isReadonly: true,
}
expect(isReadonly(evil)).toBe(false)
// get
expect(wrapped.foo).toBe(1);
});
Expand Down
10 changes: 5 additions & 5 deletions src/reactivity/src/reactive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ export const reactiveMap = new WeakMap();
export const readonlyMap = new WeakMap();
export const shallowReadonlyMap = new WeakMap();

export const enum ReactiveFlags {
IS_REACTIVE = "__v_isReactive",
IS_READONLY = "__v_isReadonly",
RAW = "__v_raw",
}
export const ReactiveFlags = {
IS_REACTIVE : Symbol("__v_isReactive"),
IS_READONLY : Symbol("__v_isReadonly"),
RAW : Symbol("__v_raw"),
} as const

export function reactive(target) {
return createReactiveObject(target, reactiveMap, mutableHandlers);
Expand Down