fw/lptim_systick: udpate obelix wdt feed logic #471
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HaiLong Yang <cameled@outlook.com>
Signed-off-by: HaiLong Yang <cameled@outlook.com>
gmarull
requested changes
Nov 17, 2025
Comment on lines
+151
to
+154
| static WDT_HandleTypeDef hwdt = { | ||
| .Instance = hwp_wdt1, | ||
| }; | ||
| __HAL_WDT_START(&hwdt); |
Collaborator
There was a problem hiding this comment.
is watchdog stopped when entering deepsleep? if so add a comment
| task_watchdog_feed(); | ||
| uint32_t current_counter = LPTIM1->CNT; | ||
| if (current_counter < wdt_last_counter) { | ||
| current_counter += 0x10000; |
Collaborator
There was a problem hiding this comment.
define magic number, e.g. LPTIM_MAX_CNT
Comment on lines
-689
to
-691
|
|
||
| // Temporarily disable stop mode (GH-452) | ||
| stop_mode_disable(InhibitorMain); |
Collaborator
There was a problem hiding this comment.
just do git revert -s 25d476dd69eb833e353868132e0864d892af3e94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contain two changes. The first is using lptim real counter to count wdt feed time. The second is call
__HAL_WDT_STARTto avoid flash access when wakeup from stop mode.Try to fix #452