Fix conda init "--no-user" argument being ignored #9739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Viacheslav Ostroukh.
|
xylar
reviewed
Oct 10, 2022
| "--no-user", | ||
| action="store_false", | ||
| action="store_true", | ||
| # help="Don't initialize conda for the current user (default).", |
Contributor
There was a problem hiding this comment.
I would suggest also fixing the help string.
Suggested change
| # help="Don't initialize conda for the current user (default).", | |
| help="Don't initialize conda for the current user.", |
This was referenced Oct 10, 2022
Member
|
Close in favor of #11949. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is being ignored, because option
no_userin https://github.com/conda/conda/blob/master/conda/cli/main_init.py#L46 is markedFalsewhen--no-useroption is present.I picked
action="store_true"instead ofdest="user"because of existance of the reference toargs.no_userin the code, probably it is left on intent.