这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@xhochy
Copy link
Contributor

@xhochy xhochy commented Jan 30, 2020

This allows the use of interactive commands like ipython.

@xhochy xhochy requested a review from a team as a code owner January 30, 2020 10:56
@cla-bot
Copy link

cla-bot bot commented Jan 30, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @xhochy. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@xhochy xhochy force-pushed the no-capture-conda-run branch from d62d0a0 to 65b3dfb Compare January 30, 2020 11:12
@cla-bot
Copy link

cla-bot bot commented Jan 30, 2020

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @xhochy. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@xhochy
Copy link
Contributor Author

xhochy commented Jan 30, 2020

Can someone give me a hint where conda run is actually tested? I fail to see the correct location.

This allows the use of interactive commands like ipython.
@xhochy xhochy force-pushed the no-capture-conda-run branch from 65b3dfb to 96517ea Compare September 15, 2020 13:32
@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 15, 2020
@xhochy
Copy link
Contributor Author

xhochy commented Sep 16, 2020

@conda/conda-core rebased and CI passed, ready for review.

@chenghlee chenghlee added this to the 4.9.0 milestone Sep 22, 2020
@chenghlee
Copy link
Contributor

Can someone give me a hint where conda run is actually tested? I fail to see the correct location.

The TestRun class in tests/test_cli.py

@xhochy xhochy force-pushed the no-capture-conda-run branch 5 times, most recently from 791d517 to 44b51de Compare September 22, 2020 15:23
@xhochy xhochy force-pushed the no-capture-conda-run branch from 44b51de to 2f96dea Compare September 22, 2020 15:32
Co-authored-by: Dave Hirschfeld <dave.hirschfeld@gmail.com>
@xhochy
Copy link
Contributor Author

xhochy commented Sep 23, 2020

Thanks @chenghlee & @dhirschfeld. I've added a test that checks that the output is not captured by conda but rather passed though. I had to move one testclass to a pytest-Test-class but since the tests are generally called by pytest, I hope this is ok.

@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants