-
Notifications
You must be signed in to change notification settings - Fork 2k
strict channel priority via 'channel_priority' config option or --strict-channel-priority CLI flag #7729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
4b31d1d to
7f4b5d8
Compare
…pveyor Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
tests/test_create.py
Outdated
| assert stderr == '' | ||
| self.assertIsInstance(stdout, str) | ||
|
|
||
| def test_anaconda_solve_time(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such performance/benchmarking tests are no bad idea, generally. Especially in light of all those index and solver changes for 4.6.x.
It could make sense to add a @pytest.mark. to those and only run them on demand and/or in a separate, e.g., nightly, job. Or, if necessary, even put them into a separate test suite or repository.
I'd probably just use some @pytest.mark.performance and/or create a test_performance.py and set
import pytest
pytestmark = pytest.mark.performance
in there.
|
@kalefranz and @mbargull just wanted to let you know that, even though it took me a while to test this, so far it has done wonders to our workflow! Thanks a lot for implementing this! |
|
Glad to hear it! Hopefully it doesn't have any nasty side effects and we can make it the default someday soon. |
|
I'll add the default value change to #7394 |
So far everything is working as expected, even the failures 😄 I'll make sure to report anything unexpected. |
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
resolves #7656
supersedes #7660