msys2 path conversion #7389
Merged
msys2 path conversion #7389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
I know you said your opinion and while I wish we'd made a different choice way back, I do think having bind mounts is a 'user' choice .. here we're just guarding against the ill effects of it WRT conda and our prefixes so us taking extra care is not a case of fixing this 'issue' in the wrong place (just my opinion). |
c65c086 to
4a5b236
Compare
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
…ficiency Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
Signed-off-by: Kale Franz <kfranz@continuum.io>
4a5b236 to
82a515f
Compare
kalefranz
added a commit
to kalefranz/conda
that referenced
this pull request
Jun 28, 2018
Signed-off-by: Kale Franz <kfranz@continuum.io>
kalefranz
added a commit
that referenced
this pull request
Jun 28, 2018
…ersion-4.5.x backport #7389 msys2 path conversion to 4.5.x
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation with @mingwandroid,
cygpath "$(cygpath -w "$PATH")"is not invariant. See #7316 for additional context. This PR is only a partial fix. A full fix would require substantial hacks and additional logic inconda.sh. It's my opinion at this time that suboptimal decisions made by upstream msys2 have lead to this situation (msys2 should have no/bin--just/usr/bin--and there'd be no bind mount for us to worry about here), and a full solution is ultimately incumbent on upstream.NOTE: This PR needs to be rebased against master following merge of #7320. The functionality in this PR will most likely be back ported to conda 4.5.x.
The first commit of this PR is 4b9e079. If reviewing, start by looking only at that commit.