Speed up find_commands() on WSL #13035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On WSL, the entire Windows PATH is inherited, and calling `isfile` (specifically, `os.stat`) across the filesystem boundary is extremely slow. Delaying the check until after pattern matching speeds things up considerably.
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @otaithleigh. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#814), and ping the bot to refresh the PR. |
Contributor
|
@conda-bot check |
jezdez
previously approved these changes
Aug 26, 2023
Member
jezdez
left a comment
There was a problem hiding this comment.
This just needs a news file, good catch!
Contributor
Author
|
Added news entry! Wasn't sure if this fell under enhancements or bug fixes, went with bug fixes |
jezdez
approved these changes
Aug 28, 2023
Member
|
@otaithleigh Totally a bugfix, thank you! |
kenodegard
approved these changes
Aug 28, 2023
Contributor
|
Would https://docs.python.org/3/library/os.html#os.scandir avoid the isfile() calls? |
3 tasks
3 tasks
dholth
pushed a commit
that referenced
this pull request
Sep 11, 2023
On WSL, the entire Windows PATH is inherited, and calling `isfile` (specifically, `os.stat`) across the filesystem boundary is extremely slow. Delaying the check until after pattern matching speeds things up considerably.
kenodegard
added a commit
that referenced
this pull request
Sep 11, 2023
* Speed up find_commands() on WSL (#13035) On WSL, the entire Windows PATH is inherited, and calling `isfile` (specifically, `os.stat`) across the filesystem boundary is extremely slow. Delaying the check until after pattern matching speeds things up considerably. --------- Co-authored-by: P. Talley <otaithleigh@users.noreply.github.com> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #13033.
On WSL, the entire Windows PATH is inherited, and calling
isfile(specifically,os.stat) across the filesystem boundary is extremely slow. Delaying the check until after pattern matching speeds things up considerably. (30s -> 1s on my machine.)I've checked on the plain Windows side, and this appears to speed things up there as well (~900ms -> ~400ms).
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?