name hash algorithm in keys to better track draft CEP #12673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenodegard
approved these changes
May 16, 2023
Contributor
Author
|
Thanks. |
jezdez
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At first I thought it would be more conservative to keep the hash key names the same, but the other PR addressing #12669 changed the whole filename. Change those key names to represent the hash algorithm used. The draft CEP is here as a PR against the conda/ceps repository.
The nominal hash and actual hash are used to track jlap changes. The nominal hash comes from the upstream file, hashed as formatted on the server. We look for those hashes in the
.jlapchangelog. The actual hash is our on-disk hash since we do not format the saved json exactly the same as the server; instead, we format it in a more compact way.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?