fix: use requests.exceptions.JSONDecodeError for ensuring compatibility with different json implementations used by requests #12683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty with different json implementations used by requests Otherwise, conda misses JSONDecodeErrors generated by simplejson if that is in the same env and thereby used by the requests package for decoding the json response. In turn, this can lead to aborting source download after trying the first given source in a meta.yaml instead of trying all of them.
jezdez
previously approved these changes
Jun 7, 2023
Member
|
@johanneskoester I can't use GitHub's merge conflict resolution due to issues on their side, but this looks good to me, and I'd appreciate a rebase if you have time. |
dholth
approved these changes
Jun 14, 2023
kenodegard
reviewed
Jun 15, 2023
|
|
||
| [tool.hatch.version.raw-options] | ||
| local_scheme = "dirty-tag" | ||
| version_scheme = "calver-by-date" |
Contributor
There was a problem hiding this comment.
Whoops, this was accidentally added back (removed in #12708)
5 tasks
This was referenced Oct 5, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, conda misses JSONDecodeErrors generated by simplejson if that is in the same env and thereby used by the requests package for decoding the json response. In turn, this can lead to aborting source download after trying the first given source in a meta.yaml instead of trying all of them.
Also see requests JSONDecodeError implementation, which either inherits from simplejson's JSONDecodeError or from the Python std libs json.JSONDecodeError.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?