Add `conda list --reverse` argument #12496

HeavenEvolved · 2023-03-16T10:36:41Z

Description

Updated conda_argparse.py file to add a new '--reverse' parameter to configure_parser_list function to add reversing functionality as requested in Issue #11954.
There were no inherent issues fixed, but a new functionality was added to reverse the output of conda list.

Resolves #11954

Checklist

Add a file to the news directory (using the template) for the next release's release notes?
Add / update necessary tests?
Add / update outdated documentation?

Feel free to suggest any changes that I should make!

Updated conda_argparse.py file to add a new '--reverse' parameter to configure_parser_list function to add reversing functionality as requested in Issue [#11954](#11954 "Issue Link").

Updated main_list.py file to add a new functionality for '--reverse' parameter to add reversing functionality as requested in Issue [#11954](#11954 "Issue Link").

Created News file with information on enhancement added in reference to Issue [#11954](#11954 "Issue Link").

conda-bot · 2023-03-16T10:36:55Z

We require contributors to sign our Contributor License Agreement and we don't have one on file for @HeavenEvolved.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

Updated main_list.py to remove trailing whitespace.

HeavenEvolved · 2023-03-16T10:45:54Z

Hi! This is my first PR ever and I am confused by the pre-commit.ci - pr errors. It says there is an error for trailing-whitespace in main_list.py. I have checked it and there was an extra whitespace at the end, which I have removed. I don't see any other trailing whitespaces remaining anymore but the check still says failure. I can't figure out if it just needs time to update or if the error still exists.

I have also already signed the CLA before starting this PR, so kindly let me know if I need to do it again or if I need to share the signed PDF.

Updated main_list.py to remove trailing whitespace.

kenodegard · 2023-03-16T13:57:34Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

kenodegard

@HeavenEvolved Thanks for working on this!

Regarding pre-commit CI, I just triggered the auto fix functionality so the whitespace issue should now be resolved.

Regarding your CLA signature, we will review new signatures later today and we'll update this PR when that is completed.

I've left some suggestions, this should be good to go once those are resolved.

conda/cli/main_list.py

conda/cli/conda_argparse.py

Simplified how args.reverse is used. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Changed how the package list is reversed. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Removed extra whitespaces. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Fixed help message formatting for conda list --reverse. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Updated argument information for --reverse by adding a default value. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

HeavenEvolved · 2023-03-16T14:07:14Z

@HeavenEvolved Thanks for working on this!

Regarding pre-commit CI, I just triggered the auto fix functionality so the whitespace issue should now be resolved.

Regarding your CLA signature, we will review new signatures later today and we'll update this PR when that is completed.

I've left some suggestions, this should be good to go once those are resolved.

Thank you @kenodegard for those suggestions! I had completely overlooked some of those, such as, adding the default value through argparse.

news/gh-11954-list-reverse

Updated News to have simplified text. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

HeavenEvolved · 2023-03-16T14:53:46Z

Committed the changes to the News document.

kenodegard

Looks good! We'll get this merged once we process your CLA signature.

HeavenEvolved · 2023-03-16T15:53:48Z

Sounds good!

kenodegard · 2023-03-22T21:07:02Z

@conda-bot check

conda/cli/main_list.py

dholth · 2023-03-23T00:19:04Z

This test for conda list was recently updated to check a variety of arguments https://github.com/conda/conda/blob/main/tests/cli/test_conda_argparse.py#L28 ; would it be a good place to add --reverse?

HeavenEvolved · 2023-03-23T01:03:25Z

This test for conda list was recently updated to check a variety of arguments https://github.com/conda/conda/blob/main/tests/cli/test_conda_argparse.py#L28 ; would it be a good place to add --reverse?

Not sure if its needed but its a small change and if needed I can make the change. @kenodegard let me know if its needed. I personally don't think there should be any conflicts with any of the display formats, but I will make the changes if needed.

HeavenEvolved · 2023-03-26T18:33:21Z

Any updates on this @kenodegard?

jezdez

It'd be great to have a test case covering this

conda/cli/main_list.py

Adding new reverse argument to testcase. Co-authored-by: Jannis Leidel <jannis@leidel.info>

kenodegard · 2023-04-07T08:12:23Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

Co-authored-by: Ken Odegard <kodegard@anaconda.com> Co-authored-by: Jannis Leidel <jannis@leidel.info> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>

HeavenEvolved added 3 commits March 16, 2023 15:34

Update File

93a90a2

Updated conda_argparse.py file to add a new '--reverse' parameter to configure_parser_list function to add reversing functionality as requested in Issue [#11954](#11954 "Issue Link").

Update File

8825a96

Updated main_list.py file to add a new functionality for '--reverse' parameter to add reversing functionality as requested in Issue [#11954](#11954 "Issue Link").

Create File

e9319d3

Created News file with information on enhancement added in reference to Issue [#11954](#11954 "Issue Link").

HeavenEvolved requested a review from a team as a code owner March 16, 2023 10:36

HeavenEvolved changed the title ~~Heaven evolved issue#11954~~ Functionality added as requested in Issue#11954 Mar 16, 2023

Update File

7d6c076

Updated main_list.py to remove trailing whitespace.

Update File

8652fd1

Updated main_list.py to remove trailing whitespace.

[pre-commit.ci] auto fixes from pre-commit.com hooks

9d75a96

for more information, see https://pre-commit.ci

kenodegard requested changes Mar 16, 2023

View reviewed changes

HeavenEvolved and others added 5 commits March 16, 2023 19:32

Update conda/cli/main_list.py

adef903

Simplified how args.reverse is used. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Update conda/cli/main_list.py

bc16df9

Changed how the package list is reversed. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Update conda/cli/main_list.py

7828e01

Removed extra whitespaces. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Update conda/cli/conda_argparse.py

e27d011

Fixed help message formatting for conda list --reverse. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

Update conda/cli/conda_argparse.py

f8bc541

Updated argument information for --reverse by adding a default value. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

kenodegard reviewed Mar 16, 2023

View reviewed changes

news/gh-11954-list-reverse Outdated Show resolved Hide resolved

Update news/gh-11954-list-reverse

aaee394

Updated News to have simplified text. Co-authored-by: Ken Odegard <kodegard@anaconda.com>

HeavenEvolved requested a review from kenodegard March 16, 2023 14:55

kenodegard previously approved these changes Mar 16, 2023

View reviewed changes

conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 22, 2023

Merge branch 'main' into HeavenEvolved-Issue#11954

595e447

kenodegard reviewed Mar 22, 2023

View reviewed changes

conda/cli/main_list.py Outdated Show resolved Hide resolved

conda/cli/main_list.py Outdated Show resolved Hide resolved

Apply suggestions from code review

f6b32a9

kenodegard dismissed their stale review via f6b32a9 March 22, 2023 21:09

kenodegard previously approved these changes Mar 22, 2023

View reviewed changes

kenodegard enabled auto-merge (squash) March 22, 2023 21:11

kenodegard changed the title ~~Functionality added as requested in Issue#11954~~ Add conda list --reverse argument Mar 22, 2023

Canonical and export formats were missed

247fc21

kenodegard dismissed their stale review via 247fc21 March 22, 2023 22:16

jezdez requested changes Mar 27, 2023

View reviewed changes

conda/cli/main_list.py Outdated Show resolved Hide resolved

Update File

da4a204

Adding new reverse argument to testcase. Co-authored-by: Jannis Leidel <jannis@leidel.info>

auto-merge was automatically disabled March 27, 2023 09:55
Head branch was pushed to by a user without write access

kenodegard added 2 commits April 7, 2023 09:51

Merge branch 'main' into HeavenEvolved-Issue#11954

d6c3faf

Add tests

57ecfec

kenodegard requested a review from jezdez April 7, 2023 08:10

kenodegard previously approved these changes Apr 7, 2023

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

e44a650

for more information, see https://pre-commit.ci

pre-commit-ci bot dismissed kenodegard’s stale review via e44a650 April 7, 2023 08:12

travishathaway approved these changes Apr 12, 2023

View reviewed changes

Merge branch 'main' into HeavenEvolved-Issue#11954

0603363

jezdez approved these changes Apr 12, 2023

View reviewed changes

jezdez merged commit de96334 into conda:main Apr 12, 2023

HeavenEvolved deleted the HeavenEvolved-Issue#11954 branch May 21, 2023 15:55

github-actions bot added the locked [bot] locked due to inactivity label May 21, 2024

github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024

Add conda list --reverse argument #12496

Add conda list --reverse argument #12496

Uh oh!

Conversation

HeavenEvolved commented Mar 16, 2023 • edited by kenodegard Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

conda-bot commented Mar 16, 2023

Uh oh!

HeavenEvolved commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenodegard commented Mar 16, 2023

Uh oh!

kenodegard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HeavenEvolved commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

HeavenEvolved commented Mar 16, 2023

Uh oh!

kenodegard left a comment

Choose a reason for hiding this comment

Uh oh!

HeavenEvolved commented Mar 16, 2023

Uh oh!

kenodegard commented Mar 22, 2023

Uh oh!

Uh oh!

Uh oh!

dholth commented Mar 23, 2023

Uh oh!

HeavenEvolved commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HeavenEvolved commented Mar 26, 2023

Uh oh!

jezdez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kenodegard commented Apr 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add `conda list --reverse` argument #12496

Add `conda list --reverse` argument #12496

HeavenEvolved commented Mar 16, 2023 •

edited by kenodegard

Loading

HeavenEvolved commented Mar 16, 2023 •

edited

Loading

HeavenEvolved commented Mar 16, 2023 •

edited

Loading

HeavenEvolved commented Mar 23, 2023 •

edited

Loading