这是indexloc提供的服务，不要输入任何密码
Skip to content

Avoid warning when environment variables have the same value of OS ones #12128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 7, 2022
Merged

Avoid warning when environment variables have the same value of OS ones #12128

merged 5 commits into from
Dec 7, 2022

Conversation

@dariocurr
Copy link
Contributor

@dariocurr dariocurr commented Nov 24, 2022 •
edited
Loading

Description

I believe that the environment variable overwriting WARNING should be printed only if the environment variables are really different from those specified in the OS

Note: another option would be to still send the message, but on stdout and not on stderr.

I have encountered this behavior dealing with the python extension of vscode, which as soon as has a message on stderr, forwards it, making itself unusable

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes? No since I didn't open an issue and I found in the folder just issue-based news names
  • Add / update necessary tests?
  • Add / update outdated documentation? No since I didn't find any documentation about this behaviour, just the printed log

@dariocurr dariocurr requested a review from a team as a code owner November 24, 2022 17:05
@conda-bot
Copy link
Contributor

conda-bot commented Nov 24, 2022

We require contributors to sign our Contributor License Agreement and we don't have one on file for @dariocurr.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@dariocurr dariocurr changed the title Avoid warning when env var has same value of os Avoid warning when environment variables have the same value of os ones Nov 24, 2022
@dariocurr
Copy link
Contributor Author

dariocurr commented Nov 24, 2022 •
edited
Loading

We require contributors to sign our Contributor License Agreement and we don't have one on file for @dariocurr.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

Done

@dariocurr dariocurr changed the title Avoid warning when environment variables have the same value of os ones Avoid warning when environment variables have the same value of OS ones Nov 25, 2022
dholth
dholth previously approved these changes Dec 5, 2022
View reviewed changes
@beeankha
Copy link
Member

beeankha commented Dec 5, 2022

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 5, 2022
@beeankha
Copy link
Member

beeankha commented Dec 6, 2022 •
edited
Loading

(there's a ton of linter-related changes included in my "fix test failures" commit, which is why the test_activate.py diff looks much larger now)

@dariocurr I was going to suggest the updates to test_activate.py as changes for you to make, but the line ranges were outside of what you had already changed on the PR so I decided to directly make these edits and then push them myself instead. Let's see how the CI tests do after this!

@dariocurr
Copy link
Contributor Author

dariocurr commented Dec 7, 2022

Perfect, thank you. Ready to go?

@dholth dholth self-requested a review December 7, 2022 13:31
@beeankha beeankha added the source::community catch-all for issues filed by community members label Dec 7, 2022
@beeankha
Copy link
Member

beeankha commented Dec 7, 2022

Thank you so much for this contribution, @dariocurr !!

@beeankha beeankha merged commit b038a8e into conda:main Dec 7, 2022
@beeankha beeankha mentioned this pull request Dec 7, 2022
Merged
@dariocurr
Copy link
Contributor Author

dariocurr commented Dec 8, 2022

Thank you @beeankha! It's a pleasure!

travishathaway pushed a commit to travishathaway/conda that referenced this pull request Dec 9, 2022
@dariocurr @beeankha @travishathaway
Avoid warning when environment variables have the same value of OS on…
e853d3d 
…es (conda#12128)

* Avoid warning when env var has same value of os

Co-authored-by: Bianca Henderson <bhenderson@anaconda.com>
@dariocurr
Copy link
Contributor Author

dariocurr commented Dec 19, 2022

I checked and this hasn't been released yet. We at buildnn would love to use it. When do you plan to release it?

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Dec 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dholth dholth dholth approved these changes

@travishathaway travishathaway travishathaway approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::community catch-all for issues filed by community members

Projects

No open projects
🧭 Planning
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dariocurr @conda-bot @beeankha @dholth @travishathaway