Document clean --all to imply --logfiles #12028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @consideRatio. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
Contributor
Author
|
I've now signed the CLA! |
Contributor
|
@conda-bot check |
kenodegard
approved these changes
Oct 28, 2022
Contributor
kenodegard
left a comment
There was a problem hiding this comment.
@consideRatio, thanks for catching this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ended up inspecting the source code to make sure that
conda clean --allalso implied--logfiles, as all but that option was listed in the description for the--allflag.This is the source code that made me conclude that
--logfileswas implied by--all.conda/conda/cli/main_clean.py
Lines 289 to 291 in fc92ea3
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?