Don't load binstar_client until needed. Part 2. #10692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
commented
May 26, 2021
| try: | ||
| self._package = self.binstar.package(self.username, self.packagename) | ||
| except errors.NotFound: | ||
| except IndexError: |
Member
Author
There was a problem hiding this comment.
NotFound is using IndexError as one parent class.
chenghlee
approved these changes
Jun 7, 2021
FaustinCarter
pushed a commit
to FaustinCarter/conda
that referenced
this pull request
Nov 27, 2021
* Don't load binstar_client until needed. * Fix flake8 issues. * Use importlib for programmatic loading of binstar. * Actually call get_server_api. Co-authored-by: Christopher Granade <cgranade@cgranade.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to check if #10659 can be made using importlib.