Remove nested if-clauses in Activator.get_export_unset_vars
#14960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #14960 will not alter performanceComparing Summary
|
f80c6f3 to
b243ab2
Compare
travishathaway
approved these changes
Jun 24, 2025
Contributor
travishathaway
left a comment
There was a problem hiding this comment.
Agree with the change. Thanks for improving the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing #14942 discovered we weren't force uppercasing for
export_metavars=False:conda/conda/activate.py
Lines 154 to 156 in a6a02ac
Flatten nested if-clauses for readability
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?