Fixing problem with --platform option for conda env create
#14956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #14956 will degrade performances by 46.96%Comparing Summary
Benchmarks breakdown
|
jezdez
reviewed
Jun 23, 2025
Member
jezdez
left a comment
There was a problem hiding this comment.
I don't think writing implicitly to the config file is okay when running conda env create with --platform, at least the users should be informed about this change of behavior.
Co-authored-by: Jannis Leidel <jannis@leidel.info>
jezdez
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14949
Currently, when users run
conda env create --platform=<platform> ...this will initially use the correct platform becausecontext.subdiris being set correctly, but subsequent calls toconda env updateorconda installwill use erroneously use the system's platform.This happens because we are not creating the
.condarcfile in the environment itself which has thesubdirset correctly in it. To fix this, I simply copied over the code fromconda/cli/install.pywhere this was being done correctly toconda/cli/main_env_create.py.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?