这是indexloc提供的服务，不要输入任何密码
Skip to content

environment.yaml spec plugin should only handle yaml files #14823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2025
Merged

environment.yaml spec plugin should only handle yaml files #14823

merged 4 commits into from
May 12, 2025

Conversation

@soapy1
Copy link
Contributor

@soapy1 soapy1 commented May 9, 2025 •
edited
Loading

Description

Fixes conda/conda-planning#46

Previously, creating an environemnt with a txt requirements file might fail. This PR fixes this, for example:

  1. create a requirements.txt file
numpy
  1. try to create the environment with conda env
$ conda env create -n testenv2 --file requirements.txt  --yes

. . .

Preparing transaction: done                                                                                  
Verifying transaction: done                                                                                  
Executing transaction: done                                                                                  
#                                                                                                            
# To activate this environment, use                                                                          
#                                                                                                            
#     $ conda activate testenv2                                                                              
#                                                                                                            
# To deactivate an active environment, use                                                                   
#                                                                                                            
#     $ conda deactivate

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@soapy1 soapy1 requested a review from a team as a code owner May 9, 2025 21:05
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review May 9, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 9, 2025
@soapy1
Copy link
Contributor Author

soapy1 commented May 9, 2025

pre-commit.ci autofix

@codspeed-hq
Copy link

codspeed-hq bot commented May 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14823 will not alter performance

Comparing soapy1:stricter-environment-yaml (a7d889f) with main (efd8ac2)

Summary

✅ 21 untouched benchmarks

@soapy1 soapy1 force-pushed the stricter-environment-yaml branch from 31a545c to 6cdf1cb Compare May 11, 2025 17:47
@soapy1
Copy link
Contributor Author

soapy1 commented May 11, 2025

pre-commit.ci autofix

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Approved in 🔎 Review May 12, 2025
@jezdez jezdez merged commit cdd6b91 into conda:main May 12, 2025
74 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review May 12, 2025
soapy1 added a commit to soapy1/conda that referenced this pull request May 17, 2025
@soapy1 @pre-commit-ci
environment.yaml spec plugin should only handle yaml files (conda#…
60a9ed0 
…14823)

* environment.yaml spec plugin should only handle yaml files

* Add news

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jaimergp jaimergp mentioned this pull request Jun 9, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jezdez jezdez jezdez approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

🔎 Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make environment.yaml environent_spec plugin more conservative in files it tries to handle

3 participants

@soapy1 @jezdez @conda-bot