Silence the error when unset variable in fish #14660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @zeyugao. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1126), and ping the bot to refresh the PR. |
kenodegard
previously approved these changes
Mar 12, 2025
Contributor
|
@conda-bot check |
CodSpeed Performance ReportMerging #14660 will not alter performanceComparing Summary
|
1 task
|
I agree with this change. Either this PR or #14752 should be merged. |
|
This problem seems to have been solved, but the code has not been merged for a long time. @kenodegard |
kenodegard
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #14659, avoid failure when unset a variable in fish
Checklist - did you ...
- [ ] Add a file to thenewsdirectory (using the template) for the next release's release notes?- [ ] Add / update necessary tests?- [ ] Add / update outdated documentation?