这是indexloc提供的服务，不要输入任何密码
Skip to content

Enable leapsecond tests for tzdb #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Enable leapsecond tests for tzdb #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47672d8
use ubuntu-24.04 for up-to-date tzdata
h-vetinari Aug 2, 2024
4916fa4
enable tzdb-tests on linux
h-vetinari Sep 4, 2024
e60ea37
enablement part two
h-vetinari Sep 4, 2024
6bc2eab
try macos-15
h-vetinari Oct 10, 2024
b9527a5
MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.42.0, and co…
h-vetinari Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/azure-pipelines-linux.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .azure-pipelines/azure-pipelines-osx.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 29 additions & 3 deletions azure-pipelines.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion conda-forge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
azure:
settings_linux:
pool:
vmImage: ubuntu-24.04
settings_osx:
pool:
vmImage: macos-14
vmImage: macos-15
bot:
abi_migration_branches:
- 18.x
Expand Down
9 changes: 4 additions & 5 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ outputs:
host:
- {{ pin_subpackage("libcxx", exact=True) }}
run:
# re-enable this once chrono implementation is in shared library
# - tzdata
# re-enable this for osx once chrono implementation is in shared library
- tzdata # [linux]
- {{ pin_subpackage("libcxx", max_pin=None) }}
run_constrained:
- __osx <12 # [osx and (sys_abi == "pre-12")]
Expand Down Expand Up @@ -96,12 +96,11 @@ outputs:
- test -f $PREFIX/lib/libc++abi.so # [linux]

# for full chrono support, libcxx needs leap-seconds.list, which
# isn't shipped in ubuntu-22.04 nor macos-14 images (ubuntu-24.04
# should have it, but isn't available in azure pipelines yet).
# isn't shipped macos-14 image
- ls -lL /usr/share/zoneinfo
# This check is intended to start failing once an image starts shipping
# that file, so we can re-enable the leapsecond portion of the tzdb-tests
- if [ 0 -ne $(ls -lL /usr/share/zoneinfo | grep leap-seconds.list | wc -l) ]; then exit 1; fi
- if [ 0 -ne $(ls -lL /usr/share/zoneinfo | grep leap-seconds.list | wc -l) ]; then exit 1; fi # [osx]

- bash compile_test.sh # [unix]
- compile_test.bat # [win]
Expand Down
6 changes: 4 additions & 2 deletions recipe/test_sources/tzdb/tzdb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ test_load_leapseconds()
std::printf("found %zu leapseconds\n", len);

// this is correct as of tzdata 2024a
// disabled currently due to missing leap-seconds.list, see meta.yaml
// VERIFY( db.leap_seconds.size() == 27 );
// disabled currently due to missing leap-seconds.list on osx, see meta.yaml
#if defined(__linux__)
VERIFY( db.leap_seconds.size() == 27 );
#endif
}

int main()
Expand Down
Loading