-
Notifications
You must be signed in to change notification settings - Fork 10.4k
updata HudControl Display lane lines #36019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
|
test_processes.py |
|
This would be awesome for commaai/opendbc#1575 — we already have access to the individual lane lines on these 10 cars, and the logic is implemented here: https://github.com/commaai/opendbc/pull/1575/files#diff-256b6a0bc4c776172e296de10551d95f65f5013dbbf8364478d35f07fffc0828R153-R154 |
Unfortunately, I don't know why the automatic check failed. I don't know whether it caused the PR to remain unreviewed. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
this worked for me, although it would need some smoothing function or delay to prevent flickering and standstill checks, unsure if this is best done here or in opendbc. |
I think it needs to be processed on OpenDBC, but it is not necessary to make any judgment on my Toyota car. |
Always display lane lines in selfdrive/controls/controlsd.py
Therefore, the improvement