这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Candy0707
Copy link

@Candy0707 Candy0707 commented Aug 19, 2025

Always display lane lines in selfdrive/controls/controlsd.py

hudControl.rightLaneVisible = True 
hudControl.leftLaneVisible = True

Therefore, the improvement

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@Candy0707 Candy0707 marked this pull request as draft August 19, 2025 15:18
@Candy0707 Candy0707 marked this pull request as ready for review August 19, 2025 17:14
@Candy0707 Candy0707 marked this pull request as draft August 19, 2025 17:27
@Candy0707 Candy0707 marked this pull request as ready for review August 19, 2025 18:03
@Candy0707
Copy link
Author

test_processes.py
As ​​long as hudControl.rightLaneVisible and hudControl.leftLaneVisible are not equal to true, the validation will fail. I'm not sure if this is a bug.

@royjr
Copy link
Contributor

royjr commented Aug 28, 2025

This would be awesome for commaai/opendbc#1575 — we already have access to the individual lane lines on these 10 cars, and the logic is implemented here: https://github.com/commaai/opendbc/pull/1575/files#diff-256b6a0bc4c776172e296de10551d95f65f5013dbbf8364478d35f07fffc0828R153-R154

@Candy0707
Copy link
Author

這對於commaai/opendbc#1575來說太棒了——我們已經可以訪問這 10 輛車上的單獨車道線,並且邏輯在這裡實現:https://github.com/commaai/opendbc/pull/1575/files#diff-256b6a0bc4c776172e296de10551d95f65f5013dbbf8364478d35f07fffc0828R153

Unfortunately, I don't know why the automatic check failed. I don't know whether it caused the PR to remain unreviewed.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Sep 8, 2025
@royjr
Copy link
Contributor

royjr commented Sep 10, 2025

this worked for me, although it would need some smoothing function or delay to prevent flickering and standstill checks, unsure if this is best done here or in opendbc.

@Candy0707
Copy link
Author

Candy0707 commented Sep 10, 2025

this worked for me, although it would need some smoothing function or delay to prevent flickering and standstill checks, unsure if this is best done here or in opendbc.

I think it needs to be processed on OpenDBC, but it is not necessary to make any judgment on my Toyota car.

@github-actions github-actions bot removed the stale label Sep 10, 2025
@Candy0707 Candy0707 closed this by deleting the head repository Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants