added path_list arg to TextFileStreamer #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
If people supply both path_list and text_base_path then unexpected behavior will occur. Seems like a check should be put in like:
assert (text_base_path is None) or (path_list is None)
Contributor
Author
There was a problem hiding this comment.
yep, agreed and done
dkrasner
pushed a commit
that referenced
this pull request
Feb 17, 2014
added path_list arg to TextFileStreamer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an argument to TextFileStreamer to allow an explicit list of paths. Ex, you want only certain files in a dir and you know what those are. In this case it will not get_path()...