cel: add a description to the AST #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuat Yessenov <kuat@google.com>
adisuissa
reviewed
May 26, 2023
xds/type/matcher/v3/cel.proto
Outdated
| @@ -35,4 +35,7 @@ option (xds.annotations.v3.file_status).work_in_progress = true; | |||
| message CelMatcher { | |||
| // Either parsed or checked representation of the CEL program. | |||
| type.v3.CelExpression expr_match = 1 [(validate.rules).message = {required: true}]; | |||
|
|
|||
| // Human-readable description of the CEL AST, e.g. the original expression text. | |||
There was a problem hiding this comment.
Consider clarifying that this could be used for debugging and is of free form (I'm assuming it is), so no need to adhere to some format.
There was a problem hiding this comment.
Made it a bit more clear about what and why.
sergiitk
added a commit
to sergiitk/envoy
that referenced
this pull request
Nov 10, 2023
cncf/xds@e9ce688...523115e - cel: add a description to the AST (cncf/xds#61) - Bump bazel to 4.2.2 (cncf/xds#68) - bazel: fix "missing strict dependencies" build issue (cncf/xds#72) - bazel version updated from `4.2.2` to `6.3.2` - `protoc-gen-validate` dependencies updated to match Envoy's Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
mattklein123
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 13, 2023
cncf/xds@e9ce688...523115e - cel: add a description to the AST (cncf/xds#61) - Bump bazel to 4.2.2 (cncf/xds#68) - bazel: fix "missing strict dependencies" build issue (cncf/xds#72) - bazel version updated from `4.2.2` to `6.3.2` - `protoc-gen-validate` dependencies updated to match Envoy's Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
update-envoy bot
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Nov 13, 2023
cncf/xds@e9ce688...523115e - cel: add a description to the AST (cncf/xds#61) - Bump bazel to 4.2.2 (cncf/xds#68) - bazel: fix "missing strict dependencies" build issue (cncf/xds#72) - bazel version updated from `4.2.2` to `6.3.2` - `protoc-gen-validate` dependencies updated to match Envoy's Signed-off-by: Sergii Tkachenko <sergiitk@google.com> Mirrored from https://github.com/envoyproxy/envoy @ b500165160ce60020ad55bf6b10c6d5cc0b5f54c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to assist debugging since AST is not easy to de-construct.